removed hash equality from yy_modelIsEqual:#279
Open
TarekkMA wants to merge 1 commit intoibireme:masterfrom
Open
removed hash equality from yy_modelIsEqual:#279TarekkMA wants to merge 1 commit intoibireme:masterfrom
TarekkMA wants to merge 1 commit intoibireme:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 99.28% 93.95% -5.33%
==========================================
Files 2 2
Lines 1540 1539 -1
Branches 0 421 +421
==========================================
- Hits 1529 1446 -83
+ Misses 11 7 -4
- Partials 0 86 +86
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #278 . hash equality won't work if the object doesn't ovrride the hash method.